Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark groovy-eclipse-compiler mojos threadsafe #972

Closed
TobiX opened this issue Oct 16, 2019 · 0 comments
Closed

Mark groovy-eclipse-compiler mojos threadsafe #972

TobiX opened this issue Oct 16, 2019 · 0 comments
Assignees
Labels
Milestone

Comments

@TobiX
Copy link

TobiX commented Oct 16, 2019

This is a followup to #449 - While the fix marked the compiler component as threadSafe, the plugin still contains the AddGroovySourceFolders mojo, which is still called out by maven:

[WARNING] *****************************************************************
[WARNING] * Your build is requesting parallel execution, but project      *
[WARNING] * contains the following plugin(s) that have goals not marked   *
[WARNING] * as @threadSafe to support parallel building.                  *
[WARNING] * While this /may/ work fine, please look for plugin updates    *
[WARNING] * and/or request plugins be made thread-safe.                   *
[WARNING] * If reporting an issue, report it against the plugin in        *
[WARNING] * question, not against maven-core                              *
[WARNING] *****************************************************************
[WARNING] The following goals are not marked @threadSafe in XXX:
[WARNING] org.codehaus.groovy:groovy-eclipse-compiler:3.4.0-01:add-groovy-build-paths
[WARNING] *****************************************************************

Probably also a good time to switch to annotation-based config:

@Mojo(name = "add-groovy-build-paths", defaultPhase = LifecyclePhase.INITIALIZE, requiresProject = true, threadSafe = true)

and for the project member:

@Parameter(defaultValue = "${project}", readonly = true)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants