Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type inferencing and syntax highlighting for super trait method and property references #953

Closed
eric-milles opened this issue Sep 16, 2019 · 2 comments
Assignees
Labels
Milestone

Comments

@eric-milles
Copy link
Member

Consider the following:

trait Auditable {
  String option
  void audit() {
    if (checkCondition()) {
      println 'audited'
    }
  }
  private static boolean checkCondition() {
    println 'condition checked'
    true
  }
}

trait Another {
  private static boolean checkCondition() {
    false
  }
}

class C implements Auditable, Another {
  void m() {
    Another.super.checkCondition()
    Auditable.super.checkCondition()
    Auditable.super.option = 'whatever'
  }
}

Syntax coloring within the method m() should be "trait" for each occurrence of Another and Auditable. And coloring should be "method" for option, which refers to the property setter method. Code select for the sub-expressions in Auditable.super.option is not working either.

image

@eric-milles eric-milles self-assigned this Sep 16, 2019
@eric-milles eric-milles added this to the v3.5.0 milestone Sep 16, 2019
@eric-milles eric-milles changed the title Fix syntax coloring and type inferencing for super trait method and property references Fix type inferencing and syntax highlighting for super trait method and property references Sep 22, 2019
@eric-milles
Copy link
Member Author

image

image

image

@eric-milles
Copy link
Member Author

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant