Internal groovy compiler error #258
Comments
|
Somewhere in your code, you have a string literal "(\.\.\\)|(\.\./)". There is a bit of code in StaticImportVisitor that tries to save information on qualified type expressions. I think your regex is getting mistaken for a qualified type expression. You must be setting this string to a static final in some class and then referencing it somewhere else, this is where the constant gets inlined. private Expression transformInlineConstants(Expression exp) {
if (exp instanceof PropertyExpression) {
PropertyExpression pe = (PropertyExpression) exp;
if (pe.getObjectExpression() instanceof ClassExpression) {
ClassExpression ce = (ClassExpression) pe.getObjectExpression();
ClassNode type = ce.getType();
if (type.isEnum()) return exp;
Expression constant = findConstant(getField(type, pe.getPropertyAsString()));
// GRECLIPSE edit
//if (constant != null) return constant;
if (constant != null) {
String name = pe.getText().replace('$', '.');
Object alias = pe.getNodeMetaData("static.import.alias");
if (alias != null && !alias.equals(pe.getPropertyAsString())) {
name += " as " + alias;
}
// store the qualified name to facilitate organizing static imports
constant.setNodeMetaData("static.import", name);
return constant;
}
// GRECLIPSE endIt is the setNodeMetaData call where the exception is being thrown. |
|
I was able to recreate with this. Does this look familiar to what you have? Using the constant reference in an annotation seems to be the critical bit. package a.b.c.d
interface E {
String F = 'G.H'
}import static a.b.c.d.E.F as X
import static a.b.c.d.E.F as Y
@SuppressWarnings([X, Y])
class C {
} |
|
Thanks for clarification. Yes, we are using such pattern as a constant for internal security check, directory traversal checks in particular. I was able to reproduce that: package test
interface TestStrings {
public static final String ONE = 'one'
public static final String TWO = 'two'
public static final String THREE = 'three'
public static final String DIRECTORY_TRAVERSAL = /(\.\.\\)|(\.\.\/)/
}package test
@interface TestAnnotation {
String[] value()
}
@interface TestAnnotation2 {
String[] value()
}package test
import static test.TestStrings.*
class Test {
@TestAnnotation(value = [ONE, TWO, DIRECTORY_TRAVERSAL])
@TestAnnotation2(value = [ONE, TWO, DIRECTORY_TRAVERSAL])
static main(args) {
println 'hello groovy'
}
}
As soon as you comment out the second @TestAnnotation2, everything will works and looks fine, but I guess it is not. |
|
Thanks for the second replay, have not seen it. Please look onto my response above. I also was able to reproduce it without static alias. The trick is to use two annotations with constant that has pattern. This code I provided mimic our production code. |
|
Thanks. This simpler class, including the interface E above does the trick: import static a.b.c.d.E.*
class Foo {
@SuppressWarnings(F)
def one() {}
@SuppressWarnings(F)
def two() {}
} |
|
Can you recheck? This should be resolved with the latest snapshot. |
|
I tested this one, it is working now, but exposed two other issues. I will file them separately. Thanks a lot! |
I have this error on almost all groovy classes on my work project since new year. Unfortunately I am unable to reproduce it on the separate simple test project. My work project is a Grails 3.x project, but I tried to use the same dependencies on the test project and I have no issue - everything working without any errors, so dependencies is not a problem. It looks like it is some strange coincidence. I tried to copy any class with internal error from my working project to a new one, but as soon as I do that it will start compiling without internal errors. Also tried to recreate project from the scratch - got internal errors on almost all groovy classes again. I will provide an error and stack trace for it. May be it will help. Please just take a look on this, may be it will give you some clue. I will try to continue to reproduce it on the separate test project, but so far - no luck. Feel free to ask me if you need more info.
I am using groovy-eclispe plugin of version: Groovy-Eclipse Feature 2.9.2.xx-201701232340-e46
No other changes was made to this project in term of dependencies, migration to new version or others and it was perfectly working in the past, until some groovy-eclipe update break it.
The error is:
Internal groovy compiler error.
Stack Trace:
The text was updated successfully, but these errors were encountered: