Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename refactor on static member should not impact aliased references #1398

Closed
eric-milles opened this issue Sep 28, 2022 · 0 comments
Closed
Assignees
Labels
Milestone

Comments

@eric-milles
Copy link
Member

eric-milles commented Sep 28, 2022

Consider the following:

import static C.m as x
class C {
  static m() {}
  static {
    this.m()
    this.&m
    C.m()
    m()
    x()
  }
}
@groovy.transform.CompileStatic
class CS {
  static m() {}
  static {
    this.m() // not C#m
    this.&m // not C#m
    C.m()
    m() // not C#m
    x()
  }
}

Rename Refactoring (Alt+Shift+R) on C#m should update "m" references but not "x" references. Currently the "x"s get changed as well. Same goes for static fields and properties.

@eric-milles eric-milles added this to the v4.7.0 milestone Sep 28, 2022
@eric-milles eric-milles self-assigned this Sep 28, 2022
@eric-milles eric-milles changed the title Rename refactor on type or static member should not impact aliased references Rename refactor on static member should not impact aliased references Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant