Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ordering and de-duplication of category method completion proposals #1153

Closed
eric-milles opened this issue Aug 14, 2020 · 1 comment
Closed

Improve ordering and de-duplication of category method completion proposals #1153

eric-milles opened this issue Aug 14, 2020 · 1 comment
Assignees
@eric-milles
Labels
enhancement
Milestone
v3.9.0

Comments

@eric-milles
Copy link
Member

When multiple options exist for a given method completion, like find(Iterable) and find(Object), ordering and de-duplication do not take into account the best match for the receiver type. For example, when the completion type is a List, there is a findAll extension method for List and a more general one for Collection. Only one is proposed for completion and at the moment they are assigned equal relevance, so the last one declared in the one proposed.

image
@eric-milles eric-milles added this to the v3.9.0 milestone Aug 14, 2020
@eric-milles eric-milles self-assigned this Aug 14, 2020
eric-milles added a commit that referenced this issue Aug 14, 2020
@eric-milles
Fix for #1153: improve de-duplication of method completion proposals
136b147
@eric-milles
Copy link
Member Author

image

eric-milles added a commit that referenced this issue Aug 14, 2020
@eric-milles
Fix for #1153: improve de-duplication of method completion proposals
fb50a87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eric-milles eric-milles

Labels
enhancement
Projects
None yet
Milestone
v3.9.0
Development

No branches or pull requests
1 participant
@eric-milles