minor fix-ups

groovy · Nov 22, 2019 · d322169 · d322169
1 parent b25e79d
commit d322169
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/base/org.codehaus.groovy30/src/org/codehaus/groovy/ast/ClassNode.java b/base/org.codehaus.groovy30/src/org/codehaus/groovy/ast/ClassNode.java
@@ -300,10 +300,9 @@ private static String computeArrayName(ClassNode componentType) {
             }
         } else if (!componentType.isArray()) {
             return "[L" + componentName + ";";
-        } else if (componentName.startsWith("[")) {
-            return "[" + componentName;
         }
-        return componentName + "[]"; // TODO: What code still creates array types like this?
+        assert componentName.startsWith("[");
+        return "[" + componentName;
     }
     // GRECLIPSE end
 

diff --git a/...lipse.jdt.groovy.core/src/org/codehaus/jdt/groovy/internal/compiler/ast/JDTClassNode.java b/...lipse.jdt.groovy.core/src/org/codehaus/jdt/groovy/internal/compiler/ast/JDTClassNode.java
@@ -667,12 +667,12 @@ public boolean isDeprecated() {
 
     @Override
     public boolean isPrimitive() {
-        return false; // FIXASC (M3) verify always true. Think it is a jdtReferenceBinding is a reference binding and not a typebinding
+        return false;
     }
 
     @Override
     public boolean isResolved() {
-        return true; // JDTClassNodes are created because of a JDT Reference Binding file so are always 'resolved' (although not initialized upon creation)
+        return true; // JDTClassNode created because of a JDT ReferenceBinding, so it is always "resolved" (although not initialized upon creation)
     }
 
     @Override