GROOVY-10051

groovy · Apr 22, 2021 · 0eb2a0f · 0eb2a0f
1 parent b8b8cbe
commit 0eb2a0f
Show file tree

Hide file tree

Showing 4 changed files with 54 additions and 0 deletions.
diff --git a/...ovy.core.tests.compiler/src/org/eclipse/jdt/groovy/core/tests/xform/TypeCheckedTests.java b/...ovy.core.tests.compiler/src/org/eclipse/jdt/groovy/core/tests/xform/TypeCheckedTests.java
@@ -2247,4 +2247,46 @@ public void testTypeChecked10049() {
 
         runConformTest(sources, "42");
     }
+
+    @Test
+    public void testTypeChecked10051() {
+        //@formatter:off
+        String[] sources = {
+            "Main.groovy",
+            "abstract class State/*<H extends Handle>*/ {\n" +
+            "  def <T extends Handle> HandleContainer<T> getHandleContainer(key) {\n" +
+            "  }\n" +
+            "}\n" +
+            "class HandleContainer<H extends Handle> {\n" +
+            "  H handle\n" +
+            "}\n" +
+            "interface Handle {\n" +
+            "  Result getResult()\n" +
+            "}\n" +
+            "class Result {\n" +
+            "  int itemCount\n" +
+            "  String[] items\n" +
+            "}\n" +
+            "@groovy.transform.TypeChecked\n" +
+            "List<String> getStrings(State state, List<?> keys) {\n" +
+            "  keys.collectMany { key ->\n" +
+            "    List<String> strings = Collections.emptyList()\n" +
+            "    \n" +
+            "    def container = state.getHandleContainer(key)\n" + // returns HandleContainer<Object> not HandleContainer<Handle>
+            "    if (container != null) {\n" +
+            "      def result = container.handle.result\n" +
+            "      if (result != null && result.itemCount > 0) {\n" +
+            "        strings = Arrays.asList(result.items)\n" +
+            "      }\n" +
+            "    }\n" +
+            "    \n" +
+            "    strings\n" +
+            "  }\n" +
+            "}\n" +
+            "print getStrings(null,[])\n",
+        };
+        //@formatter:on
+
+        runConformTest(sources, "[]");
+    }
 }
diff --git a/...rg.codehaus.groovy25/src/org/codehaus/groovy/transform/stc/StaticTypeCheckingSupport.java b/...rg.codehaus.groovy25/src/org/codehaus/groovy/transform/stc/StaticTypeCheckingSupport.java
@@ -1817,7 +1817,11 @@ private static ClassNode extractType(GenericsType gt) {
         }
         // For a placeholder, a type based on the generics type is used for the compatibility check, to match on
         // the actual bounds and not the name of the placeholder.
+        /* GRECLIPSE edit -- GROOVY-10051
         ClassNode replacementType = OBJECT_TYPE;
+        */
+        ClassNode replacementType = gt.getType().redirect();
+        // GRECLIPSE end
         if (gt.getType().getGenericsTypes() != null) {
             GenericsType realGt = gt.getType().getGenericsTypes()[0];
             if (realGt.getLowerBound() != null) {

diff --git a/...rg.codehaus.groovy30/src/org/codehaus/groovy/transform/stc/StaticTypeCheckingSupport.java b/...rg.codehaus.groovy30/src/org/codehaus/groovy/transform/stc/StaticTypeCheckingSupport.java
@@ -1731,7 +1731,11 @@ private static ClassNode extractType(final GenericsType gt) {
         }
         // For a placeholder, a type based on the generics type is used for the compatibility check, to match on
         // the actual bounds and not the name of the placeholder.
+        /* GRECLIPSE edit -- GROOVY-10051
         ClassNode replacementType = OBJECT_TYPE;
+        */
+        ClassNode replacementType = gt.getType().redirect();
+        // GRECLIPSE end
         if (gt.getType().getGenericsTypes() != null) {
             GenericsType realGt = gt.getType().getGenericsTypes()[0];
             if (realGt.getLowerBound() != null) {

diff --git a/...rg.codehaus.groovy40/src/org/codehaus/groovy/transform/stc/StaticTypeCheckingSupport.java b/...rg.codehaus.groovy40/src/org/codehaus/groovy/transform/stc/StaticTypeCheckingSupport.java
@@ -1673,7 +1673,11 @@ private static ClassNode extractType(final GenericsType gt) {
         }
         // For a placeholder, a type based on the generics type is used for the compatibility check, to match on
         // the actual bounds and not the name of the placeholder.
+        /* GRECLIPSE edit -- GROOVY-10051
         ClassNode replacementType = OBJECT_TYPE;
+        */
+        ClassNode replacementType = gt.getType().redirect();
+        // GRECLIPSE end
         if (gt.getType().getGenericsTypes() != null) {
             GenericsType realGt = gt.getType().getGenericsTypes()[0];
             if (realGt.getLowerBound() != null) {