Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix debug output of plugin class path #182

Merged
merged 2 commits into from
Dec 5, 2020
Merged

Fix debug output of plugin class path #182

merged 2 commits into from
Dec 5, 2020

Conversation

TobiX
Copy link
Contributor

@TobiX TobiX commented Dec 4, 2020

Just a minor nit: Before, there was no separator between elements, with this naive change there is one too much at the end...

@keeganwitt
Copy link
Member

keeganwitt commented Dec 4, 2020

Yea, I guess to be consistent with the other classpaths that are logged, probably this would be better (unfortunately this isn't Java 8, for compatibility, so I don't have String.join(), so it's a bit verbose):

for (int i = 0; i < pluginArtifacts.size(); i++) {
    sb.append(pluginArtifacts.get(i).getFile());
    if (i < pluginArtifacts.size() - 1) {
        sb.append(", ");
    }
}

@keeganwitt keeganwitt merged commit df5d34e into groovy:master Dec 5, 2020
@keeganwitt
Copy link
Member

Thanks for the MR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants