Added minimal logging #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewis-wf
reviewed
Jun 7, 2024
PamelaM
suggested changes
Aug 28, 2024
There was a problem hiding this comment.
This is a good addition, but I had two suggestions that block me from approving this PR. (you could always convince me, neither of them are [bug/blocking], much less [BLOCKING] -- the latter of which I've only used twice when I ran into code that would instantly corrupt data)
| @@ -268,6 +271,7 @@ def call(self, fn, *args, **kwargs): | |||
| raise RetryError(attempt) | |||
| else: | |||
| sleep = self.wait(attempt_number, delay_since_first_attempt_ms) | |||
| self._logger.info(f"Retrying in {sleep / 1000.0:.2f} seconds.") | |||
There was a problem hiding this comment.
[blocking] This line should be below the if self._wait_jitter_max: clause so that it reflects the actual wait time.
There was a problem hiding this comment.
Edit: NM, I read it to quickly 😁. Moving below 👍
| @@ -110,6 +111,7 @@ def __init__( | |||
| self._wait_jitter_max = 0 if wait_jitter_max is None else wait_jitter_max | |||
| self._before_attempts = before_attempts | |||
| self._after_attempts = after_attempts | |||
| self._logger = logging.getLogger(__name__) if logger is None else logger | |||
There was a problem hiding this comment.
[blocking] This is okay, but I hate having a library change behavior wrt logging.
Maybe something like:
if logger in (True, None):
self._logger = logging.getLogger(__name__)
if logger is None:
# -- Turn this into a Null Logger
self._logger.addHandler(logging.NullHandler())
self._logger.propagate = False
elif logger:
self._logger = logger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something like this for the issue #3 ?