Skip to content

Commit

Permalink
rc3: do not run with bash -e option
Browse files Browse the repository at this point in the history
Problem: If any step in rc3 fails, the shell immediately exits,
bypassing the rest of the shutdown. At best this results in a slew
of errors about "module was not cleanly shutdown", but at worst
could result in data loss as persistence rules could be skipped.

Remove the -e option from the rc3 shebang line so that the rc3
script produces errors but attempts to run to completion.

Fixes flux-framework#2672
  • Loading branch information
grondo committed Jan 25, 2020
1 parent 00cbfa8 commit 8723672
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion etc/rc3
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/bash -e
#!/bin/bash

core_dir=$(cd ${0%/*} && pwd -P)
all_dirs=$core_dir${FLUX_RC_EXTRA:+":$FLUX_RC_EXTRA"}
Expand Down

0 comments on commit 8723672

Please sign in to comment.