Magic mode: return Perl's interpretation of the value instead of the literal (#4) #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…literal (grondilu#4) Previously, magic mode meant qq/"-quoted strings behaved like q/'-quoted strings because it returned the value of the first argument to the overload function rather than the second. From the 'overload' perldoc: The corresponding values are references to functions which take three arguments: the first one is the initial string form of the constant, the second one is how Perl interprets this constant, the third one is how the constant is used. Note that the initial string form does not contain string delimiters, and has backslashes in backslash-delimiter combinations stripped (thus the value of delimiter is not relevant for processing of this string). The return value of this function is how this constant is going to be interpreted by Perl.
Perl's built-in rand is not cryptographically-secure. In particular, it is only seeded with 4 bytes of entropy. Bitcoin::Util::randInt appears to be an improvement but also hasn't been properly analysed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, magic mode meant qq/"-quoted strings behaved like q/'-quoted strings
because it returned the value of the first argument to the overload function
rather than the second.
From the 'overload' perldoc:
The corresponding values are references to functions which take three arguments:
the first one is the initial string form of the constant, the second one is how
Perl interprets this constant, the third one is how the constant is used. Note
that the initial string form does not contain string delimiters, and has
backslashes in backslash-delimiter combinations stripped (thus the value of
delimiter is not relevant for processing of this string). The return value of
this function is how this constant is going to be interpreted by Perl.