Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change icon for close in tag #411

Closed
wants to merge 1 commit into from
Closed

Conversation

britt6612
Copy link
Collaborator

What does this PR do?

changes the icon for remove in Tag

What testing has been done on this PR?

locally

Any background context you want to provide?

we dont use formClose icons anymore

What are the relevant issues?

needed for Tag

Screenshots (if appropriate)

Is this change backward compatible or could it be a breaking change for the official HPE theme?

How should this PR be communicated in the release notes?

yes

@britt6612 britt6612 requested a review from taysea October 2, 2024 18:41
@britt6612
Copy link
Collaborator Author

closing since grommet does not support the format of <Close size='small' />
grommet/grommet#7332

@britt6612 britt6612 closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant