Apply updated clear selection styles #412
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 2, 2024
|
Converting to draft because we want to add a theme object into Grommet to accommodate the "hover" of the clear select button. |
jcfilben
approved these changes
Oct 25, 2024
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates clear selection styles based on grommet/grommet#7397.
The
text.sizewill be able to be removed in the theme update, but this is to align with current button font sizing.What testing has been done on this PR?
grommet/hpe-design-system#4207
Any background context you want to provide?
What are the relevant issues?
Closes #410
Screenshots (if appropriate)
Is this change backward compatible or could it be a breaking change for the official HPE theme?
How should this PR be communicated in the release notes?
Fixed color contrast on "Clear selection" button in Select.