Add button-icon-a11ytitle rule #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds rule to ensure that icon-only buttons have an a11yTitle or aria-label so that the action of the button is clear to those who use assistive technologies.
Where should the reviewer start?
lib/rules/button-icon-a11ytitle.js
Can you provide a link to an AST Explorer example that validates the rule works as expected?
https://astexplorer.net/#/gist/095a0e22eac6270a717b67752003a763/dcd2b93a8c03ca618ea4356784c08218f58e15b2
Any background context you want to provide?
What are the relevant issues?
Closes #14
Screenshots (if appropriate)
Tested local in design system site
Have docs been added/updated?
Yes.
Should this PR be mentioned in the release notes?
Yes. Added
button-icon-a11ytitle.Is this change backwards compatible or is it a breaking change?
Backwards compatible.