Add formfield-htmlfor-id rule
#28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds rule that checks that FormField has
htmlForthat matches theidof its child input.Where should the reviewer start?
lib/rules/formfield-htmlfor-id.js
Can you provide a link to an AST Explorer example that validates the rule works as expected?
https://astexplorer.net/#/gist/f47559f8d3bf9decaf79d8fd7b18bd19/79717f9256f92d27686c0d87e5e06ce666659b98
Any background context you want to provide?
What are the relevant issues?
Closes #10
Screenshots (if appropriate)
Have docs been added/updated?
Yes.
Should this PR be mentioned in the release notes?
Yes. Added
formfield-htmlfor-id.Is this change backwards compatible or is it a breaking change?
Backwards compatible.