Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show parsing errors in context of line where they occur #168

Merged
merged 5 commits into from
Aug 20, 2024
Merged

Show parsing errors in context of line where they occur #168

merged 5 commits into from
Aug 20, 2024

Conversation

ldemailly
Copy link
Member

@ldemailly ldemailly commented Aug 20, 2024 •
edited
Loading

Now:

$ if true {
>    len{}
13:04:44.844 [ERR] parser error: expected next token to be `(`, got `{` instead:
   len{}
      ^
$ 1e+999 - 6
13:05:15.404 [ERR] parser error: could not parse "1e+999" as float:
1e+999 - 6
     ^
$ if foo {  % blah
13:07:21.791 [ERR] parser error: no prefix parse function for `%` found:
if foo {  % blah
          ^

Fixes #15 (at least for parsing errors, for eval time we may want a stack trace)
Fixes #166 (will follow up in discord bot PR)

@ldemailly ldemailly requested a review from ccoVeille August 20, 2024 20:03
This was referenced Aug 20, 2024
Closed
Merged
@ldemailly ldemailly merged commit 1e3deb4 into main Aug 20, 2024
1 check passed
@ldemailly ldemailly deleted the parsing_error branch August 20, 2024 22:10
ccoVeille
ccoVeille reviewed Aug 21, 2024
View reviewed changes
eval/eval.go Show resolved Hide resolved
parser/parser.go Show resolved Hide resolved
parser/parser.go Show resolved Hide resolved
parser/parser_test.go Show resolved Hide resolved
token/token.go Show resolved Hide resolved
@ccoVeille
Copy link
Contributor

I would like to recommend you

https://github.com/meyermarcel/annot

(Hi @meyermarcel 👋)

@ldemailly
Copy link
Member Author

I would like to recommend you

https://github.com/meyermarcel/annot

(Hi @meyermarcel 👋)

fancy :) I think I'm ok with my lowkey single ^ though for now :)

ldemailly added a commit that referenced this pull request Aug 21, 2024
@ldemailly
review comments from #168
7c91d2b
ldemailly added a commit that referenced this pull request Aug 21, 2024
@ldemailly
Index range expression, including right relative to the end for both …
dfb82b3 
…direct access and ranges (#171)

* Index range expression, including right relative to the end

* Add l:r to generate array of ints. handle for arrays and maps

* Handle x[n:] case

* simplify and add some basic test

* checkpoint

* review comments from #168

* allow negative (from end) access for both direct index and ranges

* use : to replace generateIndices()

* update test for negative index

* add one range test
@ccoVeille
Copy link
Contributor

I would like to recommend you

https://github.com/meyermarcel/annot

(Hi @meyermarcel 👋)

fancy :) I think I'm ok with my lowkey single ^ though for now :)

Noted. I also found https://github.com/caarlos0/mdtree

New and interesting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccoVeille ccoVeille ccoVeille left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

limit number of parsing errors Better errors, line numbers, dump the ast etc
2 participants
@ldemailly @ccoVeille