-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenAI Vision image query functionality #625
Conversation
68193b2
to
28dc699
Compare
9036b22
to
a6e7b0d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice work! Nothing major in feedback.
CHANGELOG.md
Outdated
@@ -12,6 +12,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
- `AzureMongoDbVectorStoreDriver` for using CosmosDB with MongoDB vCore API. | |||
- `vector_path` field on `MongoDbAtlasVectorStoreDriver`. | |||
- `LeonardoImageGenerationDriver` supports image to image generation. | |||
- `OpenAiVisionImageQueryDriver` to support queries on images using OpenAI's Vision model. | |||
- `ImageQueryClient` allowing an agent to make queries on images on disk or in memory. | |||
- Image Query engine and task. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Capitalize engine
and task
griptape/drivers/image_query/openai_vision_image_query_driver.py
Outdated
Show resolved
Hide resolved
griptape/tasks/image_query_task.py
Outdated
|
||
@define | ||
class ImageQueryTask(BaseTask): | ||
image_query_engine: ImageQueryEngine = field(kw_only=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll wait for #591 so we can do this and add the driver to the OpenAI config as well.
a6e7b0d
to
b4ce30d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great. Up to you whether you'd like to wait until #591 is merged in first.
@andrewfrench #591 went in, let me know if you have any questions on how to integrate here. |
57fd01c
28095c5
to
57fd01c
Compare
This PR introduces image query functionality using the OpenAI Vision model.