Extract computations notification types

[Mathieu-Deharbe]

removes a Circular dependency from #614

[sonarqubecloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
96.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[SlimaneAmar]

I think it's an anti pattern to have a constants class
https://www.baeldung.com/java-constants-good-practices

[Mathieu-Deharbe]

I don't think so : the anti-pattern described in your article is "A Large Global Constants Class" which contains everything. Here I have a "type" (ComputationsNotificationTypes) for the constant class. The NotificationService with its dozens of constants was much closer to the anti pattern in my opinion.

Look a the good pattern he describes at the end : "4.2. Constants Class"

If you prefer I can put them into ComputationType. But given that this is an enum and not a class I would have to add a nested class like this :
https://stackoverflow.com/questions/23608885/how-to-define-static-constants-in-a-java-enum