Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove previous values from table #568

Closed
wants to merge 9 commits into from
Closed

remove previous values from table #568

wants to merge 9 commits into from

Conversation

ghazwarhili
Copy link
Contributor

No description provided.

AtomicReference<Double> maxQ = new AtomicReference<>(Double.NaN);
AtomicReference<Double> minQ = new AtomicReference<>(Double.NaN);
if (!CollectionUtils.isEmpty(points)) {
IntStream.range(0, modificationPoints.size())
.forEach(i -> {
ReactiveCapabilityCurve.Point oldPoint = batteryPoints.get(i);
ReactiveCapabilityCurveModificationInfos newPoint = modificationPoints.get(i);
ReactiveCapabilityCurveCreationInfos newPoint = modificationPoints.get(i);
Double oldMaxQ = Double.NaN;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be cleaned

AtomicReference<Double> maxQ = new AtomicReference<>(Double.NaN);
AtomicReference<Double> minQ = new AtomicReference<>(Double.NaN);
if (!CollectionUtils.isEmpty(points)) {
IntStream.range(0, modificationPoints.size())
.forEach(i -> {
ReactiveCapabilityCurve.Point oldPoint = generatorPoints.get(i);
ReactiveCapabilityCurveModificationInfos newPoint = modificationPoints.get(i);
ReactiveCapabilityCurveCreationInfos newPoint = modificationPoints.get(i);
Double oldMaxQ = Double.NaN;
Copy link
Contributor

@etiennehomer etiennehomer Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be cleaned

@@ -31,4 +34,18 @@ public class ReactiveCapabilityCurveCreationEmbeddable {

@Column
private Double p;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

class to be renamed to ReactiveCapabilityCurveEmbeddable ?

@@ -81,7 +81,7 @@ public class BatteryModificationEntity extends InjectionModificationEntity {

@ElementCollection
@CollectionTable
private List<ReactiveCapabilityCurveModificationEmbeddable> reactiveCapabilityCurvePoints;
private List<ReactiveCapabilityCurveCreationEmbeddable> reactiveCapabilityCurvePoints;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to generate a liquibase changeset as you have fewer columns now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants