adjusting regulating when modifying phase tap changer

[EtienneLt]

No description provided.

[Mathieu-Deharbe]

Doesn't compile anymore because of the recent merge of my refacto (that you reviewed) : #524

Also can you please comment the ticket with your answers to the questions asked by the PO at the end of the orignal ticket ? I cannot understand if the issue is solved just with your code.

[Mathieu-Deharbe]

Small remark : I wonder how this "regulating" value is handled in this network modification now that we don't automatically set it to true. I didn't find how to modify it in the current interface.

Might be good to see this with a PO.

[thangqp]

Small remark : I wonder how this "regulating" value is handled in this network modification now that we don't automatically set it to true. I didn't find how to modify it in the current interface.

Might be good to see this with a PO.

Share the same question???? In my opinion, we should have a PR for the frontend to compute isRegulating in certain case. It seems that isRegulating in TapChangerModificationInfos is never passed from the front-end

[Mathieu-Deharbe]

I wrote a lot about the regulation mode. If this is not clear just ask me.

[thangqp]

Could you add an additional test method for the creation of extension, pls? with name e.g. testPhaseTapChangerRegulationCreation(), I see in the code coverage, it does not yet cover some required modifications, e.g https://sonarcloud.io/code?id=org.gridsuite%3Anetwork-modification-server&pullRequest=537&selected=org.gridsuite%3Anetwork-modification-server%3Asrc%2Fmain%2Fjava%2Forg%2Fgridsuite%2Fmodification%2Fserver%2Fmodifications%2FTwoWindingsTransformerModification.java&line=293

[thangqp]

Test OK, Code OK

[sonarqubecloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud