Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix connectable position adder attributes #536

Merged
merged 2 commits into from
Sep 16, 2024
+3 −2
Merged

fix connectable position adder attributes #536

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13d2594
fix connectable position adder attributes
ghazwarhili Sep 16, 2024
1c550f3
code review remarks
ghazwarhili Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/main/java/org/gridsuite/modification/server/modifications/ModificationUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -664,6 +664,7 @@ private void createNewConnectivityPosition(ConnectablePositionAdder<?> adder,
CONNECTION_NAME_FIELD_NAME);
if (connectionNameReport != null) {
reports.add(connectionNameReport);
adder.add();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will add several times the extension if several attributes are not null

}

ReportNode connectionDirectionReport = applyElementaryModificationsAndReturnReport(
Expand All @@ -673,6 +674,7 @@ private void createNewConnectivityPosition(ConnectablePositionAdder<?> adder,
CONNECTION_DIRECTION_FIELD_NAME);
if (connectionDirectionReport != null) {
reports.add(connectionDirectionReport);
adder.add();
}

ReportNode connectionPositionReport = applyElementaryModificationsAndReturnReport(
Expand All @@ -682,10 +684,8 @@ private void createNewConnectivityPosition(ConnectablePositionAdder<?> adder,
CONNECTION_POSITION_FIELD_NAME);
if (connectionPositionReport != null) {
reports.add(connectionPositionReport);
adder.add();
}

// Finalize by adding the feeder
adder.add();
EtienneLt marked this conversation as resolved.
Show resolved Hide resolved
}

public void modifyInjectionConnection(InjectionModificationInfos modificationInfos, Injection<?> injection, List<ReportNode> subReportNode) {
Expand Down
Loading