upgrade powsybl network store to v1.16.0 #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Etienne LESOT <[email protected]>
SlimaneAmar
requested changes
Sep 3, 2024
| @@ -130,6 +130,8 @@ | |||
| <dependency> | |||
| <groupId>com.powsybl</groupId> | |||
| <artifactId>powsybl-network-store-client</artifactId> | |||
| <!-- FIXME: network-store modules' version is overloaded in the dependencies section. The overloads and this property below have to be removed at next gridsuite-dependencies.version upgrade --> | |||
There was a problem hiding this comment.
<dependency>
<groupId>com.powsybl</groupId>
<artifactId>powsybl-network-store-iidm-impl</artifactId>
<version>1.16.0</version>
</dependency>
Signed-off-by: Slimane AMAR <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
Signed-off-by: Etienne LESOT <[email protected]>
EtienneLt
commented
Sep 6, 2024
| changeConnectionState(getNetwork().getTwoWindingsTransformer("trf2"), TwoSides.TWO, true, true, null); | ||
| // changeConnectionState(getNetwork().getTwoWindingsTransformer("trf1"), TwoSides.ONE, true, false, "Could not disconnect equipment 'trf1' on side ONE"); | ||
| // changeConnectionState(getNetwork().getTwoWindingsTransformer("trf1"), TwoSides.TWO, true, false, "Could not disconnect equipment 'trf1' on side TWO"); | ||
| // changeConnectionState(getNetwork().getTwoWindingsTransformer("trf2"), TwoSides.TWO, true, true, null); |
There was a problem hiding this comment.
I dont know about this test @SlimaneAmar
added 3 commits
September 9, 2024 08:53
Signed-off-by: Slimane AMAR <[email protected]>
…ion-server into upgrade-network-store-to-v1.16.0
Signed-off-by: Slimane AMAR <[email protected]>
SlimaneAmar
approved these changes
Sep 9, 2024
added 2 commits
September 9, 2024 13:06
Signed-off-by: Slimane AMAR <[email protected]>
This reverts commit 63b9019.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.