Check null values for droop and P0 (2e patch) #523
Conversation
DONE |
src/main/java/org/gridsuite/modification/server/modifications/VscModification.java
Outdated
Show resolved
Hide resolved
| if (Boolean.FALSE.equals(modificationInfos.getAngleDroopActivePowerControl()) && !isPresentDroop && !isPresentP0) { | ||
| return; | ||
| } | ||
| // at least one field is provided but not for others => NOT OK |
There was a problem hiding this comment.
| // at least one field is provided but not for others => NOT OK | |
| // at least one field is provided but not for the others => NOT OK |
There was a problem hiding this comment.
DONE!
Corrected also in modification
| } | ||
| // otherwise, i.e. all fields are not provided => OK extension will not be created |
There was a problem hiding this comment.
| // otherwise, i.e. all fields are not provided => OK extension will not be created | |
| // otherwise, i.e. none of the fields is provided => OK extension will not be created |
There was a problem hiding this comment.
DONE!
Corrected also in modification
| assertThat(getNetwork().getHvdcLine("vsc1")).isNotNull(); | ||
| HvdcLine hvdcLine = getNetwork().getHvdcLine("vsc1"); | ||
| assertThat(hvdcLine).isNotNull(); |
There was a problem hiding this comment.
Aren't you checking the same thing twice ?
There was a problem hiding this comment.
DONE!
Removed line 330
|
A PR completed for the previous PR: #512
When extension is not yet created: