Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add endpoint to apply modifications on a network, using a list of existing modifications uuids. #505

Merged
merged 10 commits into from
Aug 2, 2024
Merged

Add endpoint to apply modifications on a network, using a list of existing modifications uuids. #505

merged 10 commits into from
Aug 2, 2024

Conversation

FranckLecuyer
Copy link
Contributor

No description provided.

@ayolab ayolab self-requested a review July 30, 2024 09:35
@dbraquart dbraquart self-requested a review July 30, 2024 15:29
dbraquart
dbraquart requested changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@dbraquart dbraquart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code: a request/remark about REST naming
tests: ok

src/main/java/org/gridsuite/modification/server/NetworkModificationController.java Outdated Show resolved Hide resolved
@FranckLecuyer FranckLecuyer requested a review from dbraquart August 1, 2024 13:12
dbraquart
dbraquart approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@dbraquart dbraquart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code: ok
tests: ok

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Aug 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@FranckLecuyer FranckLecuyer merged commit ea2c095 into main Aug 2, 2024
3 checks passed
@FranckLecuyer FranckLecuyer deleted the apply_existing_modifications_from_uuids branch August 2, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayolab ayolab ayolab approved these changes

@dbraquart dbraquart dbraquart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FranckLecuyer @dbraquart @ayolab