apply lockout for non fictional switch #500
Conversation
Signed-off-by: maissa SOUISSI <[email protected]>
Signed-off-by: maissa SOUISSI <[email protected]>
There was a problem hiding this comment.
I'm not sure we want to do the change in this service. Don't we want to change it in network-store in the default method?
What's the purpose of the change? To change the disconnect behavior or only for a very specific case?
It seems very strange (wrong?) to have the two types of disconnect mixed together inside the same modification
Also, I thought we just needed to ignore fictional switch, the default was IS_CLOSED_BREAKER so I would have chosen IS_NONFICTIONAL_CLOSED_BREAKER, why IS_NONFICTIONAL_BREAKER?
=> discussed with PO, we only want to change the lockout behavior
I also don't really understand the changes in the tests.
We can also fix the sonar issue
cc @SlimaneAmar
| } | ||
|
|
||
| private boolean disconnectOneTerminal(Terminal terminal) { | ||
| return !terminal.isConnected() || terminal.disconnect(); | ||
| } | ||
|
|
||
| private boolean disconnectNonFictionalOneTerminal(Terminal terminal) { |
There was a problem hiding this comment.
Remove NonFictional in the name and pass the predicate in argument
| .add(); | ||
| assertNotNull(line); | ||
|
|
||
| line.getTerminal("v1f").disconnect(SwitchPredicates.IS_NONFICTIONAL); |
There was a problem hiding this comment.
Don't understand !
Need to create a fictional switch and test disconnect
And another tests each with a type of switch ?
.../gridsuite/modification/server/modifications/OperatingStatusModificationLockoutLineTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: maissa SOUISSI <[email protected]>
Signed-off-by: maissa SOUISSI <[email protected]>
.../gridsuite/modification/server/modifications/OperatingStatusModificationLockoutLineTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/gridsuite/modification/server/utils/NetworkCreation.java
Show resolved
Hide resolved
src/test/java/org/gridsuite/modification/server/utils/NetworkCreation.java
Outdated
Show resolved
Hide resolved
Signed-off-by: maissa SOUISSI <[email protected]>
Signed-off-by: maissa SOUISSI <[email protected]>
| @Test | ||
| public void testLockoutLinesWithLoadBreakerSwitches() throws Exception { | ||
| //Lockout line with switches of kind LOAD_BREAK_SWITCH | ||
| getNetwork().getSwitch("br11").setProperty("Kind", SwitchKind.LOAD_BREAK_SWITCH.toString()); |
There was a problem hiding this comment.
A property does not modify the type !
Signed-off-by: maissa SOUISSI <[email protected]>
…/gridsuite/network-modification-server into lockout-for-non-fictional-switch
| @@ -73,20 +99,46 @@ protected void assertAfterNetworkModificationCreation() { | |||
| TestUtils.assertOperatingStatus(getNetwork(), TARGET_LINE_ID, TARGET_BRANCH_STATUS); | |||
| } | |||
|
|
|||
| private void assertAfterNetworkModificationLockout(String lineID) throws Exception { | |||
There was a problem hiding this comment.
Rename by testLockoutLine
.../gridsuite/modification/server/modifications/OperatingStatusModificationLockoutLineTest.java
Outdated
Show resolved
Hide resolved
.../gridsuite/modification/server/modifications/OperatingStatusModificationLockoutLineTest.java
Show resolved
Hide resolved
|
Remove the Sonar issue |
Signed-off-by: maissa SOUISSI <[email protected]>
Signed-off-by: maissa SOUISSI <[email protected]>
Signed-off-by: maissa SOUISSI <[email protected]>
…/gridsuite/network-modification-server into lockout-for-non-fictional-switch
Signed-off-by: maissa SOUISSI <[email protected]>
|
No description provided.