-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the possibility to trip a busbar section. #493
Conversation
Quality Gate passedIssues Measures |
We should add at least one unit test |
Signed-off-by: BOUTIER Charly <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be improve to test better the change?
...g/gridsuite/modification/server/modifications/OperatingStatusModificationTripBusBarTest.java
Outdated
Show resolved
Hide resolved
...g/gridsuite/modification/server/modifications/OperatingStatusModificationTripBusBarTest.java
Outdated
Show resolved
Hide resolved
...g/gridsuite/modification/server/modifications/OperatingStatusModificationTripBusBarTest.java
Outdated
Show resolved
Hide resolved
...g/gridsuite/modification/server/modifications/OperatingStatusModificationTripBusBarTest.java
Outdated
Show resolved
Hide resolved
...g/gridsuite/modification/server/modifications/OperatingStatusModificationTripBusBarTest.java
Outdated
Show resolved
Hide resolved
...g/gridsuite/modification/server/modifications/OperatingStatusModificationTripBusBarTest.java
Outdated
Show resolved
Hide resolved
...g/gridsuite/modification/server/modifications/OperatingStatusModificationTripBusBarTest.java
Outdated
Show resolved
Hide resolved
...g/gridsuite/modification/server/modifications/OperatingStatusModificationTripBusBarTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: BOUTIER Charly <[email protected]>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code OK
Test OK
Needs to update the OperatingStatus in Powsybl-core and add the BUSBAR_SECTION in the isAllowedIdentifiable function to test properly.
Ask me how to if the next version of powsybl is not used yet.
Edit : This is ready