Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the possibility to trip a busbar section. #493

Merged
merged 9 commits into from
Sep 5, 2024

Conversation

EstherDarkish
Copy link
Contributor

@EstherDarkish EstherDarkish commented Jul 1, 2024

Needs to update the OperatingStatus in Powsybl-core and add the BUSBAR_SECTION in the isAllowedIdentifiable function to test properly.
Ask me how to if the next version of powsybl is not used yet.

Edit : This is ready

Copy link

@antoinebhs
Copy link
Contributor

We should add at least one unit test

BOUTIER Charly and others added 2 commits September 3, 2024 15:52
Copy link
Contributor

@antoinebhs antoinebhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be improve to test better the change?

Signed-off-by: BOUTIER Charly <[email protected]>
Copy link

sonarqubecloud bot commented Sep 5, 2024

Copy link
Contributor

@antoinebhs antoinebhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code OK
Test OK

@EstherDarkish EstherDarkish merged commit 742c211 into main Sep 5, 2024
3 checks passed
@EstherDarkish EstherDarkish deleted the trip_busbar_section branch September 5, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants