set stashed status for all modifications #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamal-khey
added a commit
that referenced
this pull request
Oct 11, 2023
Signed-off-by: jamal-khey <[email protected]>
jamal-khey
added a commit
that referenced
this pull request
Oct 11, 2023
Signed-off-by: jamal-khey <[email protected]>
jamal-khey
force-pushed
the
set-stashed-status-on-all-modifications
branch
2 times, most recently
from
2449a80 to
21c6d4f
Compare
jamal-khey
added a commit
that referenced
this pull request
Oct 11, 2023
Signed-off-by: jamal-khey <[email protected]>
jamal-khey
force-pushed
the
set-stashed-status-on-all-modifications
branch
from
b39a2b1 to
eb1d1d1
Compare
jamal-khey
added a commit
that referenced
this pull request
Oct 11, 2023
Signed-off-by: jamal-khey <[email protected]>
jamal-khey
added a commit
that referenced
this pull request
Oct 11, 2023
Signed-off-by: jamal-khey <[email protected]>
jamal-khey
added a commit
that referenced
this pull request
Oct 12, 2023
Signed-off-by: jamal-khey <[email protected]>
SlimaneAmar
requested changes
Oct 12, 2023
src/test/java/org/gridsuite/modification/server/utils/assertions/DTOAssert.java
Outdated
Show resolved
Hide resolved
|
ModificationControllerTest.testEquipmentIdNonNull |
|
Tests are failing: ModificationControllerTest.testEquipmentIdNonNull |
jamal-khey
force-pushed
the
set-stashed-status-on-all-modifications
branch
from
96dc01f to
731b577
Compare
@souissimai i fixed all test, can you please have a look again ? |
jamal-khey
added a commit
that referenced
this pull request
Oct 16, 2023
- add unit test to check stashed is set Signed-off-by: jamal-khey <[email protected]>
jamal-khey
force-pushed
the
set-stashed-status-on-all-modifications
branch
from
731b577 to
f88f951
Compare
jamal-khey
added a commit
that referenced
this pull request
Oct 16, 2023
- add unit test to check stashed is set Signed-off-by: jamal-khey <[email protected]>
souissimai
approved these changes
Oct 18, 2023
jamal-khey
force-pushed
the
set-stashed-status-on-all-modifications
branch
from
41d5fa2 to
f88f951
Compare
etiennehomer
requested changes
Oct 18, 2023
...in/java/org/gridsuite/modification/server/entities/equipment/creation/VscCreationEntity.java
Outdated
Show resolved
Hide resolved
...ite/modification/server/entities/equipment/modification/LineSplitWithVoltageLevelEntity.java
Outdated
Show resolved
Hide resolved
src/test/java/org/gridsuite/modification/server/ModificationControllerTest.java
Outdated
Show resolved
Hide resolved
...st/java/org/gridsuite/modification/server/modifications/AbstractNetworkModificationTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/gridsuite/modification/server/modifications/LineModificationTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/gridsuite/modification/server/modifications/LineModificationTest.java
Outdated
Show resolved
Hide resolved
...n/java/org/gridsuite/modification/server/entities/equipment/creation/LineCreationEntity.java
Outdated
Show resolved
Hide resolved
...rg/gridsuite/modification/server/entities/equipment/creation/VoltageLevelCreationEntity.java
Outdated
Show resolved
Hide resolved
jamal-khey
added a commit
that referenced
this pull request
Oct 18, 2023
- add unit test to check stashed is set Signed-off-by: jamal-khey <[email protected]>
jamal-khey
force-pushed
the
set-stashed-status-on-all-modifications
branch
from
9d18559 to
fe918ea
Compare
etiennehomer
requested changes
Oct 19, 2023
...rg/gridsuite/modification/server/entities/equipment/creation/VoltageLevelCreationEntity.java
Outdated
Show resolved
Hide resolved
etiennehomer
approved these changes
Oct 19, 2023
Signed-off-by: jamal-khey <[email protected]>
Signed-off-by: jamal-khey <[email protected]>
jamal-khey
force-pushed
the
set-stashed-status-on-all-modifications
branch
from
b448f22 to
17dcbe9
Compare
SlimaneAmar
approved these changes
Nov 6, 2023
src/main/java/org/gridsuite/modification/server/entities/ModificationEntity.java
Show resolved
Hide resolved
Signed-off-by: jamal-khey <[email protected]>
Signed-off-by: jamal-khey <[email protected]>
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems:
toModificationInfos() implemented in each modification, does not set the attribute "stashed"
Fix:
set this attribute in the builder of each modification