Improve stash api #337
Merged
Improve stash api #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamal-khey
force-pushed
the
improve-stash-api
branch
from
32aa89c to
15d1982
Compare
jamal-khey
added a commit
that referenced
this pull request
Oct 6, 2023
jamal-khey
added a commit
that referenced
this pull request
Oct 6, 2023
jamal-khey
added a commit
that referenced
this pull request
Oct 6, 2023
jamal-khey
added a commit
that referenced
this pull request
Oct 6, 2023
jamal-khey
force-pushed
the
improve-stash-api
branch
from
15d1982 to
a63c0d4
Compare
SlimaneAmar
reviewed
Oct 10, 2023
src/main/java/org/gridsuite/modification/server/NetworkModificationController.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/modification/server/NetworkModificationController.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/modification/server/NetworkModificationController.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/modification/server/repositories/NetworkModificationRepository.java
Outdated
Show resolved
Hide resolved
|
Remove code smells |
jamal-khey
commented
Oct 11, 2023
src/main/java/org/gridsuite/modification/server/service/NetworkModificationService.java
Outdated
Show resolved
Hide resolved
jamal-khey
added a commit
that referenced
this pull request
Oct 12, 2023
implement unit test for delete modification (#337) implement delete all modifications (#337) get all modification of a group (#337) make an api to delete only stashed modifications (#337) Signed-off-by: jamal-khey <[email protected]>
jamal-khey
force-pushed
the
improve-stash-api
branch
from
202a77a to
eb8135c
Compare
jamal-khey
added a commit
that referenced
this pull request
Oct 12, 2023
implement unit test for delete modification (#337) implement delete all modifications (#337) get all modification of a group (#337) make an api to delete only stashed modifications (#337) Signed-off-by: jamal-khey <[email protected]>
jamal-khey
force-pushed
the
improve-stash-api
branch
3 times, most recently
from
73591df to
2c3209a
Compare
SlimaneAmar
reviewed
Nov 6, 2023
src/main/java/org/gridsuite/modification/server/NetworkModificationController.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/modification/server/NetworkModificationController.java
Outdated
Show resolved
Hide resolved
jamal-khey
force-pushed
the
improve-stash-api
branch
from
2c3209a to
4af9f10
Compare
Signed-off-by: jamal-khey <[email protected]>
Signed-off-by: jamal-khey <[email protected]>
jamal-khey
force-pushed
the
improve-stash-api
branch
from
4af9f10 to
3dbcada
Compare
Signed-off-by: jamal-khey <[email protected]>
Signed-off-by: jamal-khey <[email protected]>
Signed-off-by: jamal-khey <[email protected]>
Signed-off-by: jamal-khey <[email protected]>
Signed-off-by: jamal-khey <[email protected]>
SlimaneAmar
approved these changes
Nov 7, 2023
etiennehomer
approved these changes
Nov 8, 2023
|
Tests OK |
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DELETE /network-modifications (onlyStashed=false) -> delete all modifications (also stashed modification)
DELETE /network-modifications?onlyStashed=true -> delete all stashed modifications
GET /network-modifications (onlyStashed=false) -> get all modifications (also stashed modifications)
GET /network-modifications?onlyStashed=true -> get all stashed modifications
PUT /network-modifications?stashed=true -> stash modification
PUT /network-modifications?stashed=false -> restore modification