Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix : save the regulation terminal when isRegulating is false #336

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Fix : save the regulation terminal when isRegulating is false #336

merged 2 commits into from
Sep 27, 2023

Conversation

flomillot
Copy link
Contributor

@flomillot flomillot commented Sep 25, 2023 •
edited
Loading

For 2WT, when regulating of PhaseTapChanger was false, the regulation terminal was not saved when the network modification was applied.

@flomillot flomillot requested a review from anistouri September 25, 2023 14:43
@flomillot flomillot changed the title Fix : save the regulation terminal when isRegulating is false Fix 2WT : save the regulation terminal when isRegulating is false Sep 25, 2023
@flomillot flomillot changed the title Fix 2WT : save the regulation terminal when isRegulating is false Fix : save the regulation terminal when isRegulating is false Sep 25, 2023
@ayolab ayolab self-requested a review September 25, 2023 14:57
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

75.0% 75.0% Coverage
0.0% 0.0% Duplication

@flomillot flomillot merged commit cfaa46c into main Sep 27, 2023
4 checks passed
@flomillot flomillot deleted the fix_terminal_modification_2wt branch September 27, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayolab ayolab ayolab approved these changes

@SlimaneAmar SlimaneAmar SlimaneAmar approved these changes

@anistouri anistouri anistouri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flomillot @anistouri @SlimaneAmar @ayolab