change and add some logs in generator dispatch modification #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David BRAQUART <[email protected]>
Signed-off-by: David BRAQUART <[email protected]>
Signed-off-by: David BRAQUART <[email protected]>
| if (nbNoCost > 0) { | ||
| report(reporter, reporterSuffixKey, "NbGeneratorsWithNoCost", "${nbNoCost} generator${isPlural} been discarded from generation dispatch because of missing marginal cost. Their active power set point has been set to 0", | ||
| Map.of("nbNoCost", nbNoCost, | ||
| "isPlural", nbNoCost > 1 ? "s have" : " has"), |
There was a problem hiding this comment.
"isPlural" is used for 5 times in this file, use a constant will be better ?
FranckLecuyer
requested changes
Sep 22, 2023
| disconnectedGeneratorCounter.getAndIncrement(); | ||
| }); | ||
| if (disconnectedGeneratorCounter.get() > 0) { | ||
| report(reporter, Integer.toString(componentNum), "TotalDisconnectedGenerator", "${nbDisconnectedGenerator} generator${isPlural} been discarded from generation dispatch because their are disconnected. Their active power set point remains unchanged", |
There was a problem hiding this comment.
Add the synthetic report before each individual disconnected generator report ?
| } | ||
| return marginalCost != null; | ||
| }).collect(Collectors.toList()); | ||
|
|
||
| int nbNoCost = generators.size() - generatorsWithMarginalCost.size(); | ||
| if (nbNoCost > 0) { |
There was a problem hiding this comment.
Add this synthetic report before each individual generator without marginal cost report ?
| .forEach(g -> report(reporter, suffixKey, "GeneratorUnchangedTargetP", "Generator ${generator} has not been selected by the merit order algorithm. Its active power set point has been set to 0", | ||
| Map.of(GENERATOR, g.getId()), TypedValue.TRACE_SEVERITY)); | ||
| int nbUnchangedGenerators = adjustableGenerators.size() - updatedGenerators.size(); | ||
| if (nbUnchangedGenerators > 0) { |
There was a problem hiding this comment.
Add this synthetic report before each individual unchanged generator report ?
There was a problem hiding this comment.
also made for updated generators (synthetic before details)
Signed-off-by: David BRAQUART <[email protected]>
dbraquart
force-pushed
the
change-functional-logs-for-generator-dispatch
branch
from
d5d4f8d to
75566ee
Compare
FranckLecuyer
approved these changes
Sep 26, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.