-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the shunt compensators modifications in the voltage init modification #324
Add the shunt compensators modifications in the voltage init modification #324
Conversation
…tion Signed-off-by: Franck LECUYER <[email protected]>
Signed-off-by: Franck LECUYER <[email protected]>
acb011f
to
df13cca
Compare
Signed-off-by: Franck LECUYER <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code: I propose a code simplification
tests: ok, but one remark (maybe a known issue):
- in the logs tab, after modification build, we cannot see the MCS modifications in the right/tree part. We only see "Generator xxx" items. EDIT: I meant in the "left/tree part" ;-)
src/main/java/org/gridsuite/modification/server/modifications/VoltageInitModification.java
Show resolved
Hide resolved
src/main/java/org/gridsuite/modification/server/modifications/VoltageInitModification.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/modification/server/modifications/VoltageInitModification.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Franck LECUYER <[email protected]>
To have modifications on shunts, you must provide shunt compensators filter(s) in the settings : And, In the logs, for performance reasons, there is a limitation on the number of sub reports displayed in the tree, which is 500. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code: ok
tests: ok
Kudos, SonarCloud Quality Gate passed! |
No description provided.