Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the shunt compensators modifications in the voltage init modification #324

Merged
merged 9 commits into from
Sep 19, 2023

Conversation

FranckLecuyer
Copy link
Contributor

No description provided.

@FranckLecuyer FranckLecuyer force-pushed the add_voltage_init_shunt_compensator_modifications branch from acb011f to df13cca Compare September 11, 2023 15:32
Copy link
Contributor

@dbraquart dbraquart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code: I propose a code simplification
tests: ok, but one remark (maybe a known issue):

  • in the logs tab, after modification build, we cannot see the MCS modifications in the right/tree part. We only see "Generator xxx" items. EDIT: I meant in the "left/tree part" ;-)

Signed-off-by: Franck LECUYER <[email protected]>
@FranckLecuyer
Copy link
Contributor Author

FranckLecuyer commented Sep 13, 2023

code: I propose a code simplification tests: ok, but one remark (maybe a known issue):

* in the logs tab, after modification build, we cannot see the MCS modifications in the right/tree part. We only see "Generator xxx" items.

To have modifications on shunts, you must provide shunt compensators filter(s) in the settings :
Voltage profile initialization --> Equipment selection --> Variable shunt compensators
Otherwise, no shunt will be modified ...

And, In the logs, for performance reasons, there is a limitation on the number of sub reports displayed in the tree, which is 500.

Copy link
Contributor

@dbraquart dbraquart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code: ok
tests: ok

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

96.7% 96.7% Coverage
0.0% 0.0% Duplication

@FranckLecuyer FranckLecuyer merged commit 1e81bc8 into main Sep 19, 2023
@FranckLecuyer FranckLecuyer deleted the add_voltage_init_shunt_compensator_modifications branch September 19, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants