code review

gridsuite · Nov 19, 2024 · 40f52c0 · 40f52c0
1 parent ca05914
commit 40f52c0
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 15 deletions.
diff --git a/...dsuite/modification/server/entities/equipment/modification/BatteryModificationEntity.java b/...dsuite/modification/server/entities/equipment/modification/BatteryModificationEntity.java
@@ -74,7 +74,7 @@ public class BatteryModificationEntity extends InjectionModificationEntity {
     })
     private BooleanModificationEmbedded reactiveCapabilityCurve;
 
-    @ElementCollection(fetch = FetchType.EAGER)
+    @ElementCollection
     @CollectionTable
     @OrderColumn(name = "pos_point")
     private List<ReactiveCapabilityCurveModificationEmbeddable> reactiveCapabilityCurvePoints;

diff --git a/...dification/server/entities/equipment/modification/ConverterStationModificationEntity.java b/...dification/server/entities/equipment/modification/ConverterStationModificationEntity.java
@@ -61,7 +61,7 @@ public class ConverterStationModificationEntity extends InjectionModificationEnt
     })
     private DoubleModificationEmbedded voltageSetpoint;
 
-    @ElementCollection(fetch = FetchType.EAGER)
+    @ElementCollection
     @CollectionTable(name = "converter_station_modification_rcc_points")
     @OrderColumn(name = "pos_point")
     private List<ReactiveCapabilityCurveModificationEmbeddable> reactiveCapabilityCurvePoints;

diff --git a/...uite/modification/server/entities/equipment/modification/GeneratorModificationEntity.java b/...uite/modification/server/entities/equipment/modification/GeneratorModificationEntity.java
@@ -198,7 +198,7 @@ public class GeneratorModificationEntity extends InjectionModificationEntity {
     })
     private BooleanModificationEmbedded reactiveCapabilityCurve;
 
-    @ElementCollection(fetch = FetchType.EAGER)
+    @ElementCollection
     @CollectionTable
     @OrderColumn(name = "pos_point")
     private List<ReactiveCapabilityCurveModificationEmbeddable> reactiveCapabilityCurvePoints;

diff --git a/...server/entities/equipment/modification/ReactiveCapabilityCurveModificationEmbeddable.java b/...server/entities/equipment/modification/ReactiveCapabilityCurveModificationEmbeddable.java
@@ -12,7 +12,6 @@
 import lombok.AllArgsConstructor;
 import lombok.Getter;
 import lombok.NoArgsConstructor;
-import org.gridsuite.modification.server.dto.ReactiveCapabilityCurveModificationInfos;
 
 /**
  * @author Ayoub LABIDI <ayoub.labidi at rte-france.com>
@@ -40,15 +39,4 @@ public class ReactiveCapabilityCurveModificationEmbeddable {
 
     @Column
     private Double oldP;
-
-    public ReactiveCapabilityCurveModificationInfos toInfos() {
-        return ReactiveCapabilityCurveModificationInfos.builder()
-                .p(p)
-                .oldP(oldP)
-                .minQ(minQ)
-                .oldMinQ(oldMinQ)
-                .maxQ(maxQ)
-                .oldMaxQ(oldMaxQ)
-                .build();
-    }
 }