fix: PR remarks

Signed-off-by: LE SAULNIER Kevin <[email protected]>
gridsuite · Sep 9, 2024 · 125041f · 125041f
1 parent a253d51
commit 125041f
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 7 deletions.
diff --git a/src/main/java/org/gridsuite/modification/server/NetworkModificationController.java b/src/main/java/org/gridsuite/modification/server/NetworkModificationController.java
@@ -243,12 +243,11 @@ public ResponseEntity<Void> stashNetworkModifications(
     }
 
     @PutMapping(value = "/network-modifications", produces = MediaType.APPLICATION_JSON_VALUE, params = "active")
-    @Operation(summary = "stash or unstash network modifications")
-    @ApiResponse(responseCode = "200", description = "The network modifications were stashed")
+    @Operation(summary = "enable or disable network modifications")
+    @ApiResponse(responseCode = "200", description = "The network modifications were updated successfully")
     public ResponseEntity<Void> updateNetworkModificationsActivation(
         @Parameter(description = "Network modification UUIDs") @RequestParam("uuids") List<UUID> networkModificationUuids,
-        @Parameter(description = "Group UUID") @RequestParam("groupUuid") UUID groupUuid,
-        @Parameter(description = "stash or unstash network modifications") @RequestParam(name = "active") Boolean active) {
+        @Parameter(description = "enable or disable network modifications") @RequestParam(name = "active") Boolean active) {
         networkModificationService.updateNetworkModificationActivation(networkModificationUuids, active);
         return ResponseEntity.ok().build();
     }

diff --git a/src/main/java/org/gridsuite/modification/server/dto/ModificationInfos.java b/src/main/java/org/gridsuite/modification/server/dto/ModificationInfos.java
@@ -101,7 +101,7 @@ public class ModificationInfos {
     private String messageValues;
 
     @Schema(description = "Modification enabled")
-    @NonNull
+    @Builder.Default
     private Boolean active = true;
 
     // Only for metadata

diff --git a/...erver/entities/equipment/modification/attribute/EquipmentAttributeModificationEntity.java b/...erver/entities/equipment/modification/attribute/EquipmentAttributeModificationEntity.java
@@ -71,7 +71,6 @@ public EquipmentAttributeModificationInfos toModificationInfos() {
             .date(getDate())
             .stashed(getStashed())
             .active(getActive())
-            .active(getActive())
             .equipmentId(getEquipmentId())
             .equipmentAttributeName(getAttributeName())
             .equipmentAttributeValue(getAttributeValue())

diff --git a/...java/org/gridsuite/modification/server/modifications/LineCreationInMixedTypologyTest.java b/...java/org/gridsuite/modification/server/modifications/LineCreationInMixedTypologyTest.java
@@ -44,7 +44,6 @@ protected ModificationInfos buildModification() {
         return LineCreationInfos.builder()
             .stashed(false)
             .active(true)
-            .active(true)
             .equipmentId("idLine1")
             .equipmentName("nameLine1")
             .r(100.0)