-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use dlq to handle computation errors #148
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Joris Mancini <[email protected]>
Signed-off-by: Joris Mancini <[email protected]>
1d2c055
to
f7553ae
Compare
Signed-off-by: Joris Mancini <[email protected]>
f7553ae
to
1beed8e
Compare
Signed-off-by: Joris Mancini <[email protected]>
<!-- FIXME: powsybl-ws-commons modules'version is overloaded in the dependencies section | ||
The overloads and this property below have to be removed at next powsybl-ws-dependencies.version upgrade --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To remove also or to keep but use it in the override?
quorum: | ||
enabled: true | ||
delivery-limit: 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure, but in my deployment I needed to remove manually the existing queue (that was a classic queue). What to do on our deployments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not set default type to quorum, I took the branch of gridsuite/deployment#469
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in dev since we don't persist data, docker compose down and then up is enough to force to recreate the queues. You don't need a special branch in the deployment, explicit quorum queues are already supporter in the rabbitmq version that we use on main (3.13.x)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking "what to do for our dev/rec/production envs?" as I did manual actions on my local deployment
pom.xml
Outdated
@@ -94,6 +93,11 @@ | |||
<dependencyManagement> | |||
<dependencies> | |||
<!-- overrides of imports --> | |||
<dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<!-- FIXME: to be removed at next powsybl-ws-dependencies upgrade -->
Quality Gate passedIssues Measures |
No description provided.