Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use dlq to handle computation errors #148

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

TheMaskedTurtle
Copy link
Contributor

No description provided.

Signed-off-by: Joris Mancini <[email protected]>
Comment on lines 59 to 60
<!-- FIXME: powsybl-ws-commons modules'version is overloaded in the dependencies section
The overloads and this property below have to be removed at next powsybl-ws-dependencies.version upgrade -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To remove also or to keep but use it in the override?

Comment on lines +37 to +39
quorum:
enabled: true
delivery-limit: 2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, but in my deployment I needed to remove manually the existing queue (that was a classic queue). What to do on our deployments?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not set default type to quorum, I took the branch of gridsuite/deployment#469

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in dev since we don't persist data, docker compose down and then up is enough to force to recreate the queues. You don't need a special branch in the deployment, explicit quorum queues are already supporter in the rabbitmq version that we use on main (3.13.x)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking "what to do for our dev/rec/production envs?" as I did manual actions on my local deployment

pom.xml Outdated
@@ -94,6 +93,11 @@
<dependencyManagement>
<dependencies>
<!-- overrides of imports -->
<dependency>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

        <!-- FIXME: to be removed at next powsybl-ws-dependencies upgrade  -->

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants