Migrate reducer to TypeScript #2187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tristan-WorkGH
force-pushed
the
migrate-reducer-ts
branch
from
9c182a8 to
651fe8d
Compare
achour94
requested changes
Jul 25, 2024
| @@ -41,7 +41,7 @@ import { | |||
| import { buildNode, getUniqueNodeName, unbuildNode } from '../services/study'; | |||
| import RestoreNodesDialog from './dialogs/restore-node-dialog'; | |||
| import ScenarioEditor from './graph/menus/dynamic-simulation/scenario-editor'; | |||
| import { StudyDisplayMode } from '../redux/reducer.type'; | |||
| import { StudyDisplayMode } from '../redux/reducer'; | |||
There was a problem hiding this comment.
it creates a circular dependency
There was a problem hiding this comment.
yes, it's not the only one...
| @@ -28,7 +28,7 @@ import { useIntl } from 'react-intl'; | |||
| import CropFreeIcon from '@mui/icons-material/CropFree'; | |||
| import { nodeTypes } from './graph/util/model-constants'; | |||
| import { BUILD_STATUS } from './network/constants'; | |||
| import { StudyDisplayMode } from '../redux/reducer.type'; | |||
| import { StudyDisplayMode } from '../redux/reducer'; | |||
There was a problem hiding this comment.
it creates a circular dependency
There was a problem hiding this comment.
💬 discussion in #2187 (comment)
Meklo
requested changes
Jul 25, 2024
src/components/graph/menus/dynamic-simulation/event-modification-scenario-editor.tsx
Outdated
Show resolved
Hide resolved
src/components/graph/menus/dynamic-simulation/event-modification-scenario-editor.tsx
Show resolved
Hide resolved
src/components/dialogs/network-modifications/by-formula/formula/formula-form.tsx
Outdated
Show resolved
Hide resolved
achour94
requested changes
Jul 26, 2024
Tristan-WorkGH
force-pushed
the
migrate-reducer-ts
branch
from
eaf984b to
2471746
Compare
Tristan-WorkGH
force-pushed
the
migrate-reducer-ts
branch
from
2471746 to
66432b1
Compare
Meklo
requested changes
Aug 1, 2024
Tristan-WorkGH
force-pushed
the
migrate-reducer-ts
branch
from
8f6250f to
bb82996
Compare
Meklo
approved these changes
Aug 1, 2024
achour94
approved these changes
Aug 2, 2024
Tristan-WorkGH
force-pushed
the
migrate-reducer-ts
branch
from
4bf6f4a to
b301be7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.