Optim, add user identities cache #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dentity is already known. Signed-off-by: sBouzols <[email protected]>
jonenst
approved these changes
Dec 19, 2024
|
code ok, untested |
src/utils/rest-api.ts
Outdated
| return Promise.resolve(); | ||
| } | ||
| console.info('fetching users identities for %s elements.', elementUuids.length); | ||
| console.debug('fetching users identities for elements: %s', elementUuids); |
There was a problem hiding this comment.
is this debug line necessary ?
Signed-off-by: sBouzols <[email protected]>
Signed-off-by: sBouzols <[email protected]>
|
EstherDarkish
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a local cache and avoid multiple fetches if identity is already known.
If some user identities fetch return errors for some sub, it will retry during navigation if an element is owned or lastly modified by this user in the directory.