Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Organize files by filter type #75

Merged
merged 33 commits into from
Nov 8, 2023
Merged

Organize files by filter type #75

merged 33 commits into from
Nov 8, 2023

Conversation

antoinebhs
Copy link
Contributor

No description provided.

@antoinebhs antoinebhs mentioned this pull request Nov 2, 2023
Merged
@antoinebhs antoinebhs requested a review from thangqp November 2, 2023 14:18
@antoinebhs
Copy link
Contributor Author

To avoid code duplication, I had to create AbstractLineFilter and AbstractTransformerFilter.

@antoinebhs antoinebhs requested a review from flomillot November 2, 2023 14:28
Base automatically changed from expert-filter to main November 2, 2023 16:39
@antoinebhs antoinebhs requested review from SlimaneAmar and removed request for flomillot November 3, 2023 14:05
thangqp
thangqp reviewed Nov 7, 2023
View reviewed changes
Copy link
Contributor

@thangqp thangqp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, using ''IdentifierListxxx" is some thing so technical with 'List', may be simplified by "Identifierxxx" or "Identifiersxxx" (avec 's')?

@thangqp thangqp self-requested a review November 7, 2023 11:51
@antoinebhs
Refactor line and transformer filter entities
7efb0aa 
In order to be able to organize files by filter type.

Signed-off-by: BOUHOURS Antoine <[email protected]>
@antoinebhs antoinebhs mentioned this pull request Nov 7, 2023
Merged
@antoinebhs antoinebhs changed the base branch from main to refactor-line-transformer-entities November 7, 2023 13:12
@antoinebhs
Refactor line and transformer filter entities
1402a2a 
In order to be able to organize files by filter type.

Signed-off-by: BOUHOURS Antoine <[email protected]>
@antoinebhs
Merge branch 'refactor-line-transformer-entities' of https://github.c…
6fb2934 
…om/gridsuite/filter-server into organize-by-filter

Signed-off-by: BOUHOURS Antoine <[email protected]>
@antoinebhs
Merge branch 'refactor-line-transformer-entities' of https://github.c…
b8c5d46 
…om/gridsuite/filter-server into organize-by-filter

Signed-off-by: BOUHOURS Antoine <[email protected]>
@antoinebhs
Merge branch 'refactor-line-transformer-entities' of https://github.c…
7651ddf 
…om/gridsuite/filter-server into organize-by-filter

Signed-off-by: BOUHOURS Antoine <[email protected]>
@antoinebhs
Add test
5bcc1c1 
Signed-off-by: BOUHOURS Antoine <[email protected]>
@antoinebhs
Add test
e4ae602 
Signed-off-by: BOUHOURS Antoine <[email protected]>
@antoinebhs
Add test
3864019 
Signed-off-by: BOUHOURS Antoine <[email protected]>
@antoinebhs
Merge branch 'refactor-line-transformer-entities' of https://github.c…
0490fe7 
…om/gridsuite/filter-server into organize-by-filter

Signed-off-by: BOUHOURS Antoine <[email protected]>
@antoinebhs
Merge branch 'refactor-line-transformer-entities' of https://github.c…
aef44f8 
…om/gridsuite/filter-server into organize-by-filter
Base automatically changed from refactor-line-transformer-entities to main November 8, 2023 10:09
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

88.8% 88.8% Coverage
1.9% 1.9% Duplication

@antoinebhs antoinebhs merged commit b543040 into main Nov 8, 2023
4 checks passed
@antoinebhs antoinebhs deleted the organize-by-filter branch November 8, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thangqp thangqp thangqp approved these changes

@SlimaneAmar SlimaneAmar SlimaneAmar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antoinebhs @SlimaneAmar @thangqp