Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic Simulation - Database - Rework on model's parameter definitions #65

Merged
merged 22 commits into from
Jul 10, 2023
Merged

Dynamic Simulation - Database - Rework on model's parameter definitions #65

merged 22 commits into from
Jul 10, 2023

Conversation

thangqp
Copy link
Contributor

@thangqp thangqp commented Jun 5, 2023 •
edited
Loading

  • Change relation of ModelEntity and ModelParameterDefinitionEntity from Composition to Aggregation for the reason of reuse parameter definitions in different models
  • Provide CRUD endpoints for injecting parameter definitions into a model
  • Rework on bootstrap script sql IEEE14

Bonus : Some small Hibernate-related rectifications on ModelVariableDefinitionEntity and ModelVariableSetEntity entities which are following to the previous PR: #61

Note : due to the lack of data migration.. the fastest way to migrate data in the current deployment is truncate all tables then rerun the script IEEE14Models.sql. The truncate tables are done in the liquibase script of this PR

@thangqp thangqp added the WIP label Jun 5, 2023
@thangqp thangqp removed the WIP label Jun 6, 2023
@thangqp thangqp changed the title Dynamic Simulation - Rework on model's parameter definitions database Dynamic Simulation - Database - Rework on model's parameter definitions Jun 6, 2023
@thangqp thangqp added the WIP label Jun 12, 2023
@thangqp
Remove cleanup associations when delete a variable set due to the cha…
d77ad06 
…nge from one-to-many to many-to-many with variable definition
@thangqp thangqp removed the WIP label Jun 14, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

90.3% 90.3% Coverage
0.0% 0.0% Duplication

@thangqp thangqp merged commit 587cebc into main Jul 10, 2023
@thangqp thangqp deleted the dynamic_simulation_rework_on_model_parameter_definitions branch July 10, 2023 08:59
@Tristan-WorkGH Tristan-WorkGH mentioned this pull request Oct 9, 2023
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonenst jonenst jonenst approved these changes

@geofjamg geofjamg Awaiting requested review from geofjamg

@gautierbureau gautierbureau Awaiting requested review from gautierbureau

@flo-dup flo-dup Awaiting requested review from flo-dup

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thangqp @jonenst