rework : split AuthenticationRouter into atomic component #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 1, 2024 12:37
Signed-off-by: capyq <[email protected]>
Signed-off-by: capyq <[email protected]>
| @@ -77,10 +45,10 @@ function AuthenticationRouter({ | |||
| alignItems="center" | |||
| direction="column" | |||
| > | |||
| {userManager.error !== null && ( | |||
| {userManager.error && ( | |||
There was a problem hiding this comment.
We can have an empty string if we haven't retrieve the error message.
| error: string | null; | ||
| }; | ||
|
|
||
| export interface AuthenticationRouterProps { |
There was a problem hiding this comment.
Don't we keep the props near the component?
There was a problem hiding this comment.
In this case, I use this type in other files, which is why I could change it if asked.
added 2 commits
August 8, 2024 11:05
Signed-off-by: capyq <[email protected]>
It's a minimal rework of the component; the service will be reworked later. |
|
@TheMaskedTurtle, rebase done. |
TheMaskedTurtle
approved these changes
Sep 16, 2024
|
capyq
added a commit
that referenced
this pull request
Sep 30, 2024
Signed-off-by: capyq <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract subcomponents into their own files.