Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to airbnb eslint #466

Merged
merged 23 commits into from
Jul 9, 2024
Merged

Switch to airbnb eslint #466

merged 23 commits into from
Jul 9, 2024

Conversation

ayolab
Copy link
Contributor

@ayolab ayolab commented Jun 6, 2024

No description provided.

ayolab added 5 commits June 6, 2024 19:49
@ayolab
Switch to airbnb eslint
da8728c 
Signed-off-by: Ayoub LABIDI <[email protected]>
@ayolab
Fix license headers
d2274ee 
Signed-off-by: Ayoub LABIDI <[email protected]>
@ayolab
Fix CI & add airbnb hooks rules
5ca8d79 
Signed-off-by: Ayoub LABIDI <[email protected]>
@ayolab
Fix tests
13832e6 
Signed-off-by: Ayoub LABIDI <[email protected]>
@ayolab
Fix
43ff74c 
Signed-off-by: Ayoub LABIDI <[email protected]>
TheMaskedTurtle
TheMaskedTurtle requested changes Jun 10, 2024
View reviewed changes
.eslintrc.json Outdated Show resolved Hide resolved
babel.config.json Show resolved Hide resolved
src/components/AuthenticationRouter/index.ts Outdated Show resolved Hide resolved
src/components/DirectoryItemSelector/directory-item-selector.tsx Outdated Show resolved Hide resolved
src/components/MuiVirtualizedTable/ColumnHeader.tsx Outdated Show resolved Hide resolved
src/components/inputs/react-query-builder/custom-react-query-builder.tsx Outdated Show resolved Hide resolved
src/components/inputs/react-query-builder/value-editor.tsx Outdated Show resolved Hide resolved
src/hooks/useSnackMessage.ts Show resolved Hide resolved
src/utils/AuthService.ts Outdated Show resolved Hide resolved
src/utils/MetaData.ts Outdated Show resolved Hide resolved
ayolab added 3 commits June 11, 2024 08:58
@ayolab
Requested changes
f3422bc 
Signed-off-by: Ayoub LABIDI <[email protected]>
@ayolab
Merge branch main
7b02100 
Signed-off-by: Ayoub LABIDI <[email protected]>
@ayolab
requested changes second batch
2b560f6 
Signed-off-by: Ayoub LABIDI <[email protected]>
Tristan-WorkGH
Tristan-WorkGH requested changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@Tristan-WorkGH Tristan-WorkGH left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll finish the review later, my navigator nearly freeze with 187 files to show...

.eslintrc.json Show resolved Hide resolved
babel.config.json Show resolved Hide resolved
.eslintrc.json Outdated Show resolved Hide resolved
demo/data/TreeViewFinder.jsx Show resolved Hide resolved
demo/src/FlatParametersTab.jsx Show resolved Hide resolved
demo/src/TableTab.jsx Show resolved Hide resolved
demo/src/TreeViewFinderConfig.jsx Show resolved Hide resolved
demo/src/app.jsx Outdated Show resolved Hide resolved
@ayolab
Requested changes
194b030 
Signed-off-by: Ayoub LABIDI <[email protected]>
@ayolab ayolab force-pushed the switch_to_airbnb_eslint branch from 7c54a6f to 194b030 Compare June 19, 2024 15:41
ayolab added 2 commits June 20, 2024 16:53
@ayolab
reorganize dependencies
f8a60b2 
Signed-off-by: Ayoub LABIDI <[email protected]>
@ayolab
Merge branch main
2bb6576 
Signed-off-by: Ayoub LABIDI <[email protected]>
Tristan-WorkGH
Tristan-WorkGH approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@Tristan-WorkGH Tristan-WorkGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not satisfied by some rules, but I unblock the PR.

@ayolab ayolab changed the title Switch to airbnb eslint [WIP] Switch to airbnb eslint Jul 1, 2024
Tristan-WorkGH
Tristan-WorkGH reviewed Jul 1, 2024
View reviewed changes
Copy link
Contributor

@Tristan-WorkGH Tristan-WorkGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some remarks and questions

src/components/Login/Login.tsx Outdated Show resolved Hide resolved
src/components/Login/Logout.tsx Outdated Show resolved Hide resolved
src/components/MuiVirtualizedTable/KeyedColumnsRowIndexer.tsx Outdated Show resolved Hide resolved
src/components/MuiVirtualizedTable/KeyedColumnsRowIndexer.tsx Show resolved Hide resolved
src/components/MuiVirtualizedTable/KeyedColumnsRowIndexer.tsx Show resolved Hide resolved
src/components/DirectoryItemSelector/directory-item-selector.tsx Outdated Show resolved Hide resolved
src/components/TopBar/AboutDialog.tsx Show resolved Hide resolved
src/components/TopBar/AboutDialog.tsx Show resolved Hide resolved
src/components/TopBar/AboutDialog.tsx Outdated Show resolved Hide resolved
src/components/TopBar/AboutDialog.tsx Show resolved Hide resolved
TheMaskedTurtle
TheMaskedTurtle requested changes Jul 1, 2024
View reviewed changes
src/components/Login/Login.tsx Outdated Show resolved Hide resolved
src/components/Login/Logout.tsx Outdated Show resolved Hide resolved
src/components/TopBar/TopBar.tsx Show resolved Hide resolved
src/utils/AuthService.ts Outdated Show resolved Hide resolved
@ayolab
Requested changes + fixes
752c9f7 
Signed-off-by: Ayoub LABIDI <[email protected]>
@ayolab ayolab changed the title [WIP] Switch to airbnb eslint Switch to airbnb eslint Jul 2, 2024
@ayolab ayolab requested a review from TheMaskedTurtle July 8, 2024 14:50
Tristan-WorkGH
Tristan-WorkGH approved these changes Jul 8, 2024
View reviewed changes
src/components/ElementSearchDialog/tag-renderer.tsx Outdated Show resolved Hide resolved
src/components/TopBar/AboutDialog.tsx Outdated Show resolved Hide resolved
@ayolab
Requested changes
5a05492 
Signed-off-by: Ayoub LABIDI <[email protected]>
@ayolab ayolab merged commit 2982d4b into main Jul 9, 2024
3 checks passed
@ayolab ayolab deleted the switch_to_airbnb_eslint branch July 9, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tristan-WorkGH Tristan-WorkGH Tristan-WorkGH approved these changes

@TheMaskedTurtle TheMaskedTurtle Awaiting requested review from TheMaskedTurtle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ayolab @TheMaskedTurtle @Tristan-WorkGH