Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Filter context #460

Merged
merged 18 commits into from
May 29, 2024
Merged

Remove Filter context #460

merged 18 commits into from
May 29, 2024

Conversation

Meklo
Copy link
Contributor

@Meklo Meklo commented May 29, 2024

No description provided.

@Meklo Meklo requested review from Tristan-WorkGH and flomillot May 29, 2024 09:59
Tristan-WorkGH
Tristan-WorkGH requested changes May 29, 2024
View reviewed changes
src/utils/ElementAttributes.ts Outdated Show resolved Hide resolved
src/services/apps-metadata.ts Outdated Show resolved Hide resolved
src/services/apps-metadata.ts Outdated Show resolved Hide resolved
src/services/apps-metadata.ts Outdated Show resolved Hide resolved
src/services/directory.ts Outdated Show resolved Hide resolved
src/components/TopBar/TopBar.tsx Outdated Show resolved Hide resolved
@Meklo Meklo requested a review from Tristan-WorkGH May 29, 2024 11:42
TheMaskedTurtle
TheMaskedTurtle approved these changes May 29, 2024
View reviewed changes
src/services/apps-metadata.ts Outdated Show resolved Hide resolved
flomillot
flomillot requested changes May 29, 2024
View reviewed changes
src/services/apps-metadata.ts Outdated Show resolved Hide resolved
@Meklo Meklo requested a review from flomillot May 29, 2024 12:33
Tristan-WorkGH
Tristan-WorkGH requested changes May 29, 2024
View reviewed changes
src/utils/ElementAttributes.ts Outdated Show resolved Hide resolved
@Meklo Meklo requested a review from Tristan-WorkGH May 29, 2024 12:58
Tristan-WorkGH
Tristan-WorkGH approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@Tristan-WorkGH Tristan-WorkGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tristan-WorkGH
Tristan-WorkGH reviewed May 29, 2024
View reviewed changes
Copy link
Contributor

@Tristan-WorkGH Tristan-WorkGH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to up the version in package.json.

@Meklo
Copy link
Contributor Author

Meklo commented May 29, 2024 •
edited
Loading

Don't forget to up the version in package.json.

@anistouri prepared a PR dedicated to it so I think I'll go with it

@Meklo Meklo requested a review from flomillot May 29, 2024 13:46
@Tristan-WorkGH Tristan-WorkGH mentioned this pull request May 29, 2024
Merged
@Meklo Meklo merged commit 508d80d into main May 29, 2024
3 checks passed
@Meklo Meklo deleted the feat/remove_filter_context branch May 29, 2024 14:30
@Tristan-WorkGH Tristan-WorkGH mentioned this pull request Jul 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tristan-WorkGH Tristan-WorkGH Tristan-WorkGH approved these changes

@TheMaskedTurtle TheMaskedTurtle TheMaskedTurtle approved these changes

@flomillot flomillot flomillot approved these changes

Assignees

@Meklo Meklo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Meklo @TheMaskedTurtle @flomillot @Tristan-WorkGH