Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed resizestop event name on API docs #978

Closed
wants to merge 1 commit into from

Conversation

fedesnieg
Copy link

The event name was wrong on the API docs. The correct event name is resizestop

@coveralls
Copy link

Coverage Status

Coverage remained the same at 65.23% when pulling 9b68d8e on fedesnieg:develop into 590bc34 on gridstack:develop.

@adumesny
Copy link
Member

No it is not named wrong (maybe 'resizedone' would been clearer?) - see #398
gs has to have a custom event that is guaranteed to be AFTER the normal resizestop event sent in which we update our sizes, otherwise you might get called first. I'll update the doc.

@adumesny adumesny mentioned this pull request Mar 29, 2019
@radiolips
Copy link
Member

Thanks for pointing this out, @fedesnieg , and thanks @adumesny for taking care of updating the docs.

@radiolips radiolips closed this Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants