Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

load() now creates in order #2720

Merged
merged 1 commit into from
Jun 26, 2024
Merged

load() now creates in order #2720

merged 1 commit into from
Jun 26, 2024

Conversation

adumesny
Copy link
Member

Description

  • changed code to create widgets in sorted order instead of reverse order (fixed collision code to handle that case to push down items during collision)
  • updated two.html to force collision loading to test

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing (yarn test)
  • Extended the README / documentation, if necessary

@adumesny
load() now creates in order
ec3c7e4 
* changed code to create widgets in sorted order instead of reverse order (fixed collision code to handle that case to push down items during collision)
* updated two.html to force collision loading to test
@adumesny adumesny merged commit 3bb9f0b into gridstack:master Jun 26, 2024
@adumesny adumesny mentioned this pull request Jun 26, 2024
Merged
3 tasks
@Samg217 Samg217 mentioned this pull request Jul 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@adumesny