support for multiple drag handles #2709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adumesny
reviewed
Jun 24, 2024
| @@ -55,6 +55,8 @@ export class DDDraggable extends DDBaseImplement implements HTMLElementExtendOpt | |||
| protected dragElementOriginStyle: Array<string>; | |||
| /** @internal */ | |||
| protected dragEl: HTMLElement; | |||
There was a problem hiding this comment.
you should remove that if you are using a list instead... and fix line 146
adumesny
added a commit
to adumesny/gridstack.js
that referenced
this pull request
Jun 24, 2024
* more for gridstack#2709 * corerctly removed prev dragEl code and use list
3 tasks
|
fixed your incorrect code... didn't get to test touch devices, hopefully didn't break e.target case.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently when options handle is defined it applies event listeners to the first instance that has the handle class. These changes add the events to all elements that has the handle class allowing for multiple drag handles with in a grid item