Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: prevent throwing error when node.grid is undefined (drag item from outside the grid) #2698

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Bugfix: prevent throwing error when node.grid is undefined (drag item from outside the grid) #2698

merged 1 commit into from
Jun 13, 2024

Conversation

adrianbenjuya
Copy link

@adrianbenjuya adrianbenjuya commented Jun 13, 2024 •
edited
Loading

Description

I added an extra nullcheck before performing the key event callback. If n or n.grid aren't defined then just return.

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing (yarn test)
  • Extended the README / documentation, if necessary

@adrianbenjuya adrianbenjuya mentioned this pull request Jun 13, 2024
Open
@adumesny adumesny merged commit ca007ad into gridstack:master Jun 13, 2024
@adumesny
Copy link
Member

thanks. the real fix would handle null grid (dragginbg from outside) case for #2695

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrianbenjuya @adumesny