New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NaN inf loop when using cellHeight rem/em #2361

Merged

adumesny merged 1 commit into gridstack:master from adumesny:master

Jun 12, 2023

Member

adumesny commented Jun 12, 2023

Description

fix Gridstack from v8 "maximum call stack size exceeded" crash error when cellheight is set with "rem" value #2357 and added demo for it

Checklist

Created tests which fail without the change (if possible)
All tests passing (yarn test)
Extended the README / documentation, if necessary


          NaN inf loop when using cellHeight rem/em

d75627d

* fix gridstack#2357 and added demo for it

adumesny merged commit b7543f3 into gridstack:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet