fix scroll problem when scrollbar on html element #1751
Conversation
src/utils.ts
Outdated
| //So for 'html', we compare pointer position/height against viewport, for which top is 0, | ||
| //if some inner element is our scrollElement, we must compare it to the client position of that element. | ||
| let offsetTop = 0; | ||
| if (scrollEl != document.scrollingElement) { |
There was a problem hiding this comment.
!== please
also maybe use this.getScrollElement() (which I JUST RENAMED but changed to use document.scrollingElement 2 weeks ago from document.documentElement for Safari and being correct). This way there is only 1 place to change (if ever)
src/utils.ts
Outdated
| @@ -351,7 +351,18 @@ export class Utils { | |||
| static updateScrollResize(event: MouseEvent, el: HTMLElement, distance: number): void { | |||
| const scrollEl = this.getScrollParent(el); | |||
| const height = scrollEl.clientHeight; | |||
| const offsetTop = scrollEl.getBoundingClientRect().top; | |||
| //when does pointer move out of visible area, which is then fixed by scrolling that element? | |||
There was a problem hiding this comment.
not sure that first line help - also wrong syntax.
Also please change comments to '// ' (add space)
can we maybe rephrase this comment ? It's not helping me. I would document why we need offsetTop at all, THEN explain that document HTML is different due to returning viewport and not actual needed height. or something like that...
I have not looked into this so taking you word for it. Also add #1745 #1727 to your comment.
|
thank you! |
Description
fix for issue #1745
looks like browsers are quirky beyond believe.
The properties .clientHeight and .getBoundingClientRect() are inconsistent for regular elements compared to the outmost 'html' element.
Hope you don't mind the verbose comment, and sorry for being late to look at this problem.
Have also enhanced test file covering previous problem of #1727 to contain an additional scrollbar on html element to see any adverse effects, of course such scrollbar defeats the concept of automatically scrolling while user drags something, since you don't know what needs to be moved.
Checklist
yarn test)