Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

collision overall Part II - 50% coverage check #1628

Merged
merged 1 commit into from
Feb 20, 2021
Merged

collision overall Part II - 50% coverage check #1628

merged 1 commit into from
Feb 20, 2021

Conversation

adumesny
Copy link
Member

@adumesny adumesny commented Feb 20, 2021 •
edited
Loading

Description

more fix for #1094 (part II of #1621)

  • we now check for >50% coverage (using pixel drag vs target region) before
    we collide during a drag to replace
  • this means we now support larger size swapping at their mid point.
    target is always used for mid point.

Note: web demo (#1094) is still not totally ideal as item 9 goes side way for some reason...

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing (yarn test)
  • Extended the README / documentation, if necessary

@adumesny
collision overall Part II - 50% coverage check
dd1f24b 
more fix for gridstack#1094 (part II of gridstack#1621)
* we now check for >50% coverage (using pixel drag vs target region) before
we collide during a drag to replace
* this means we now support larger size swapping at their mid point.
target is always used for mid point.

Note: web demo (gridstack#1094) is still not totally ideal as item 9 goes side way for some reason...
@adumesny adumesny merged commit 58a83af into gridstack:develop Feb 20, 2021
@adumesny
Copy link
Member Author

adumesny commented Feb 20, 2021 •
edited
Loading

showing 50% coverage (sized 2 instead of 1 items)

20210219_225342.mp4

web demo (still some issues left, especially placing below)

20210219_225827.mp4

this stuff is HARD!!

@adumesny adumesny mentioned this pull request Feb 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@adumesny