force typescript 3.6 as 3.7 has breaking change #1517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* force Typescript 3.6.5 as >3.7 has getter breaking change forcing all users of this lib to be >3.7 to compile. * they should have made this a 4.x thing see microsoft/TypeScript#33939 otherwise you get: error TS1086: An accessor cannot be declared in an ambient context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
users of this lib to be >3.7 to compile.
see TS 3.7: --declaration output for getter only property now is a getter instead of
readonlymicrosoft/TypeScript#33939otherwise you get:
error TS1086: An accessor cannot be declared in an ambient context.Checklist
yarn test)