Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom drag element of type button doesn't work #2677

Closed
gili-lumigo opened this issue May 20, 2024 · 1 comment · Fixed by #2681
Closed

Custom drag element of type button doesn't work #2677

gili-lumigo opened this issue May 20, 2024 · 1 comment · Fixed by #2681

Comments

@gili-lumigo
Copy link

Subject of the issue

When using a custom handler to be an element of type button, The drag doesn't work at all.
It used to work on version 7.3.0 and stopped working on version 8.0.0.
From what I'm seeing, It's only for buttons... If I'm using other kinds of element (For ex. a span) it does work.

Your environment

  • version of gridstack.js - 8.0.0
  • which browser/OS - Chrome

Steps to reproduce

An example can be found here:
https://jsfiddle.net/gili_lumigo/t7vuycoL/3/

When the handler is of type button, The drag doesn't work and when it's of type span, It does

Expected behavior

Should work as prior to version 8 where the drag element works regardless of the element type.

adumesny added a commit to adumesny/gridstack.js that referenced this issue May 26, 2024
* fix gridstack#2677
* allow event target to be draggable even if in the blocked list if that is the specified handle.
@adumesny
Copy link
Member

fixed in the next release. don't forget to donate if you find this lib useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants